Code Review & System (Re)Architecture


1

I've recently been brought on with a small startup to serve as their technical advisor to a group of developers offshore. The product is an ASP .NET WebForms application. One of my first tasks was to complete a code review, looking specifically for areas that perform poorly or may have bugs. I quickly found that the team has been working without any clear roadmap - code is hacked together to accommodate new feature requests as they come in.

I'm going to suggest that the code is refactored into several smaller projects and assemblies, with each serving a clear responsibility. The developers have a wealth of knowledge on the product and so I need to be especially careful about how I approach this. The last thing I need is stressed out coders or hurt feelings. Still, we can't afford to continue on as in the past. And the refactor needs to happen sooner rather than later.

Can anyone offer suggestions on how I can present the problems without making their hard work sound like a terrible mess? If additional information is needed I can provide it - to a point. I am working under an NDA so the detail will need to be obfuscated.

Management Outsourcing Project Management Team

asked Jun 29 '11 at 01:24
Blank
Yuck
257 points
  • Yuck - can you say how "offshore" these devs are? (My inclination if at all possible would be to get alongside them, physically if possible, and make them feel like you're part of the solution rather than an outsider throwing grenades from afar...) – Steve Wilkinson 9 years ago
  • @Steve: The company I'm consulting with is based in the United States, and their development team is in India. Meeting in person is very likely to happen at some point over the course of our relationship but it may not be for awhile yet. Thanks for the suggestion! – Yuck 9 years ago

3 Answers


3

A good start would be to limit yourself to asking questions instead of giving answers.

"Why is this code all in one file?"

"What are some ways you could make the code easier for new developers to understand?"

Etc. Your questions can be pretty leading but you're just asking questions, which prevents people from going on the defensive.

answered Jun 29 '11 at 03:38
Blank
Joel Spolsky
13,482 points
  • This is a great answer and touches on what I am really trying to avoid, which is sounding like a hero. The developers have been working on this project for over a year. I know I would hate it is some outsider came late to the party and started spouting off on how he feels things should be done. – Yuck 9 years ago

3

You state that you were tasked to look for code that:

perform[ed] poorly

or

may have bugs

I think you are a little bit off the reservation on this one with the desire to have beautiful more maintainable code.

You won't win points with management taking time away from new features to rewrite working code. However, I am sure they will all understand that the future maintainability of the codebase is important.

Why don't you start with profiling some code or picking some code that has defects and doing the kinds of re-factoring that you desire. If you get your hands dirty and lead by example it might help. Standing on a soap box and talking about refactoring and coding practices does not go over well - but if you show that the results are beneficial you might get some people to do the talking for you.

Pick your battles. Look for low-hanging fruit. Be careful.

answered Jun 29 '11 at 11:31
Blank
Tim J
8,346 points

0

You also might want to try being as honest as you can with them:

"I don't want to come off like a jerk, but the reason I was hired is to provide some clear direction for the code base, at times this may sound like criticism, but it's not. It's an overwhelming job, and I'll need your expertise with the code to help me get it done. I really, don't want to offend anyone, but I'm sure as everyone knows, there are times when you have to pull a project back to center."

Meh, something like that anyway. People like to "help" others, makes them feel needed instead of just being told what to do and is often a better attitude for both sides anyway.

answered Jun 29 '11 at 05:47
Blank
Dan Williams
166 points

Your Answer

  • Bold
  • Italic
  • • Bullets
  • 1. Numbers
  • Quote
Not the answer you're looking for? Ask your own question or browse other questions in these topics:

Management Outsourcing Project Management Team